-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
docs: update testing setupTimeout and add teardownTimeout
#32868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
WalkthroughThe documentation for end-to-end testing has been updated to reflect changes in the default timeout values for the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/1.getting-started/17.testing.md (1)
607-608: Capitalise “Windows” for consistency and correctness“windows” is a proper noun referring to the Microsoft OS and should be capitalised.
- - Default: `120000` or `240000` on windows + - Default: `120000` or `240000` on Windows
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/1.getting-started/17.testing.md(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: applies to **/e2e/**/*.{ts,js} : write end-to-end tests using playwright and `@nuxt/test-utils`...
Learnt from: CR
PR: nuxt/nuxt#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-18T16:46:07.446Z
Learning: Applies to **/e2e/**/*.{ts,js} : Write end-to-end tests using Playwright and `@nuxt/test-utils`
Applied to files:
docs/1.getting-started/17.testing.md
📚 Learning: applies to **/*.{test,spec}.{ts,tsx,js,jsx} : write unit tests for core functionality using `vitest`...
Learnt from: CR
PR: nuxt/nuxt#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-18T16:46:07.446Z
Learning: Applies to **/*.{test,spec}.{ts,tsx,js,jsx} : Write unit tests for core functionality using `vitest`
Applied to files:
docs/1.getting-started/17.testing.md
🪛 LanguageTool
docs/1.getting-started/17.testing.md
[grammar] ~607-~607: “Windows” (operating system by Microsoft) is a proper noun and needs to be capitalized.
Context: ...r - Default:120000or240000on windows -teardownTimeout`: The amount of tim...
(A_WINDOWS)
[uncategorized] ~609-~609: Loose punctuation mark.
Context: ...240000 on windows - teardownTimeout: The amount of time (in milliseconds) to...
(UNLIKELY_OPENING_PUNCTUATION)
🔇 Additional comments (1)
docs/1.getting-started/17.testing.md (1)
609-611:teardownTimeoutentry reads well – no further changes neededThe description, type annotation, and default value align with the existing documentation style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/1.getting-started/17.testing.md (1)
607-607: Capitalise “Windows” and tighten wording“Windows” is a proper noun and should be capitalised. Placing the alternative default in parentheses also reads better.
- - Default: `120000` or `240000` on windows + - Default: `120000` (or `240000` on Windows)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/1.getting-started/17.testing.md(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: applies to **/e2e/**/*.{ts,js} : write end-to-end tests using playwright and `@nuxt/test-utils`...
Learnt from: CR
PR: nuxt/nuxt#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-18T16:46:07.446Z
Learning: Applies to **/e2e/**/*.{ts,js} : Write end-to-end tests using Playwright and `@nuxt/test-utils`
Applied to files:
docs/1.getting-started/17.testing.md
📚 Learning: applies to **/*.{test,spec}.{ts,tsx,js,jsx} : write unit tests for core functionality using `vitest`...
Learnt from: CR
PR: nuxt/nuxt#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-18T16:46:07.446Z
Learning: Applies to **/*.{test,spec}.{ts,tsx,js,jsx} : Write unit tests for core functionality using `vitest`
Applied to files:
docs/1.getting-started/17.testing.md
🪛 LanguageTool
docs/1.getting-started/17.testing.md
[grammar] ~607-~607: “Windows” (operating system by Microsoft) is a proper noun and needs to be capitalized.
Context: ...r - Default:120000or240000on windows -teardownTimeout`: The amount of tim...
(A_WINDOWS)
[uncategorized] ~609-~609: Loose punctuation mark.
Context: ...240000 on windows - teardownTimeout: The amount of time (in milliseconds) to...
(UNLIKELY_OPENING_PUNCTUATION)
🔇 Additional comments (1)
docs/1.getting-started/17.testing.md (1)
609-611:teardownTimeoutdocs look goodThe new option’s description, type, and default match the upstream implementation. No changes needed.
📚 Description
While looking at the
@nuxt/test-utilspackage I noticedsetupTimeoutdefault value was updated andteardownTimeoutwas added in this commit nuxt/test-utils@af2ddf2This PR updates
setupTimeoutdefault value and addsteardownTimeout