Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jan 17, 2020

This PR contains the following updates:

Package Type Update Change
fork-ts-checker-webpack-plugin dependencies major ^3.1.1 -> ^4.1.2

Release Notes

TypeStrong/fork-ts-checker-webpack-plugin

v4.1.2

Compare Source

Bug Fixes

v4.1.1

Compare Source

Bug Fixes
  • add a warning message for SIGINT (4013a3f)

v4.1.0

Compare Source

Features

v4.0.5

Compare Source

Bug Fixes

v4.0.4

Compare Source

Bug Fixes
  • prevent null-pointer error after killing child process (642b5bf), closes #​363

v4.0.3

Compare Source

Bug Fixes
  • change import of crypto (1c82006)

v4.0.2

Compare Source

Bug Fixes

v4.0.1

Compare Source

Bug Fixes
  • bump patch version because of previous misconfiguration (27f2719)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jan 17, 2020
@renovate renovate bot force-pushed the renovate/fork-ts-checker-webpack-plugin-4.x branch 3 times, most recently from 16bbb22 to 5511150 Compare January 27, 2020 09:59
@renovate renovate bot force-pushed the renovate/fork-ts-checker-webpack-plugin-4.x branch from 5511150 to 16b2343 Compare February 13, 2020 08:06
@renovate renovate bot force-pushed the renovate/fork-ts-checker-webpack-plugin-4.x branch from 16b2343 to 95f7db6 Compare February 26, 2020 09:37
@renovate renovate bot force-pushed the renovate/fork-ts-checker-webpack-plugin-4.x branch from 95f7db6 to 0c25c85 Compare March 12, 2020 08:20
@kevinmarrec kevinmarrec added the help wanted Extra attention is needed label Mar 12, 2020
@kevinmarrec
Copy link
Contributor

@rchl @danielroe @NickBolles any help is appreciated if you guys know how to migrate to the new webpack plugin version. It seems some options of the plugin OR that the signature of the plugin itself have changed and just make the thing broken when trying to upgrade ^^

@renovate renovate bot force-pushed the renovate/fork-ts-checker-webpack-plugin-4.x branch 2 times, most recently from 4150678 to 15028db Compare March 22, 2020 19:07
@NickBolles
Copy link

@kevinmarrec or whoever looks at this next. I took a few minutes to look at this. I'm not too sure whats going on. here's some info though:
webpack package versions:

 ~> yarn list --pattern *webpack*
yarn list v1.22.4
├─ @nuxt/[email protected]
├─ @nuxt/[email protected]
│  └─ @types/[email protected]
├─ @nuxt/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
│  └─ [email protected]
└─ [email protected]

I don't see anything that would obviously cause this from thee fork-ts-checker-webpack-plugin 4.0 release notes

@rchl
Copy link
Collaborator

rchl commented Mar 25, 2020

It seems to do with how the new version of fork-ts-checker-webpack-plugin is compiled. Previously it targeted es6 and code was compiled into classes where methods pass the instanceof Function check while currently it's compiling to es5 target and methods are added through prototype chain and no longer pass instanceof Function check.

This problem only manifests itself when combined with jest mocking the function (bug jestjs/jest#6329 which is a duplicate of unsolved one).

@rchl
Copy link
Collaborator

rchl commented Mar 25, 2020

Created PR #322 with a fix.

@renovate renovate bot force-pushed the renovate/fork-ts-checker-webpack-plugin-4.x branch from 15028db to 150cfc0 Compare March 26, 2020 13:26
@NickBolles
Copy link

@rchl woah. Gnarly one! Nice job!

@renovate renovate bot deleted the renovate/fork-ts-checker-webpack-plugin-4.x branch March 27, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants