fix(#1626): obey splitright/below when splitting existing windows #1641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
Oct 11, 2022
| local split_side = (view.View.side == "right") and "aboveleft" or "belowright" | ||
|
|
||
| local create_new_window = #api.nvim_list_wins() == 1 | ||
| local new_window_side = (view.View.side == "right") and "aboveleft" or "belowright" |
Member
Author
There was a problem hiding this comment.
I resisted further refactoring.
Member
Author
|
Test cases: Each of
Tested with
|
kyazdani42
approved these changes
Oct 11, 2022
alex-courtis
deleted the
1626-open-file-split-not-obeying-splitright-splitbelow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1626
splitright and splitbelow were not being obeyed when splitting a non-nvim-tree window.