refactor(#2830): multi instance nvim-tree.marks #2838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Your review would be most gratefully appreciated @raaymax I've invited you to the project for easier PRs and issue management. |
alex-courtis
commented
Jul 14, 2024
| return function(node, ...) | ||
| node = node or lib.get_node_at_cursor() | ||
| fn(node, ...) | ||
| return fn(node, ...) |
alex-courtis
commented
Jul 14, 2024
| return explorer[explorer_member][member_method](explorer[explorer_member], ...) | ||
| end | ||
| end) | ||
| end |
Member
Author
There was a problem hiding this comment.
This isn't the final state, but will allow for easier class creation.
alex-courtis
commented
Jul 14, 2024
| ---@return HighlightedString[]|nil icons | ||
| function DecoratorBookmarks:calculate_icons(node) | ||
| if marks.get_mark(node) then | ||
| if core.get_explorer() and core.get_explorer().marks:get_mark(node) then |
Member
Author
There was a problem hiding this comment.
Impractical to access Explorer at this point.
alex-courtis
commented
Jul 14, 2024
| if explorer then | ||
| for _, node in pairs(explorer.marks:get_marks()) do | ||
| status.bookmarks[node.absolute_path] = node.type | ||
| end |
Member
Author
There was a problem hiding this comment.
Impractical to access Explorer at this point.
raaymax
reviewed
Jul 15, 2024
Collaborator
raaymax
left a comment
raaymax
left a comment
There was a problem hiding this comment.
Seen, applied changes to my PR. Seems legit to me.
Member
Author
Many thanks, I'll let you go first - you're making all the progress. |
Member
Author
|
Pushing this one through; it's been soaking for a week and won't interfere with the other 2 WIP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2830