-
-
Couldn't load subscription status.
- Fork 529
test: refactor e2e tests to use helper for checking status message #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@DorianMazur hopefully this is less flakey . Writing up the PR description when I get back to my laptop |
|
Will do the same for all statues |
…mproved clarity and consistency
|
ah doesnt work on ios |
- due to `ResetDevice` properly resetting our tests
|
@DorianMazur I think I may have got them stable |
|
streamline wait times in authHelpers this test failed because of unsure what caused it though |
|
@DorianMazur lmk what you think :) |
|
@Bowlerr I will check this PR and others in next week |
This PR updates the E2E tests to improve the handling and assertion of credential status messages by:
new helper functions for:
expectCredentialsLoadedMessageexpectCredentialsSavedMessageexpectCredentialsResetMessageRefactor test with new helpers.
added new helper for
expectRegexTextthat uses another new helperretryto try mitigate the tests being flakey even though screenshots are showing they have passed.These changes aim to improve maintainability and consistency of the tests.