Skip to content

fix: Apply border radius to inner view(progress bar) when applying padding to <Progress.Bar /> #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Apply border radius to inner view(progress bar) when applying padding to <Progress.Bar /> #247

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9e3f3d
add inner borderRadius
Apr 28, 2022
8872222
add inner borderRadius
Apr 28, 2022
4db6308
add inner borderRadius
Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions Bar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { Animated, Easing, View, I18nManager } from 'react-native';
import { Animated, Easing, View } from 'react-native';

const INDETERMINATE_WIDTH_FACTOR = 0.3;
const BAR_WIDTH_ZERO_POSITION =
Expand Down Expand Up @@ -142,26 +142,18 @@ export default class ProgressBar extends Component {
const progressStyle = {
backgroundColor: color,
height,
borderRadius: 1000,
width: this.state.progress.interpolate({
inputRange: [0, 1],
outputRange: [0.0001, innerWidth]
}),
transform: [
{
translateX: this.state.animationValue.interpolate({
inputRange: [0, 1],
outputRange: [innerWidth * -INDETERMINATE_WIDTH_FACTOR, innerWidth],
}),
},
{
translateX: this.state.progress.interpolate({
inputRange: [0, 1],
outputRange: [innerWidth / (I18nManager.isRTL ? 2 : -2), 0],
}),
},
{
// Interpolation a temp workaround for https://github.com/facebook/react-native/issues/6278
scaleX: this.state.progress.interpolate({
inputRange: [0, 1],
outputRange: [0.0001, 1],
}),
},
],
};

Expand All @@ -176,4 +168,4 @@ export default class ProgressBar extends Component {
</View>
);
}
}
}