-
Notifications
You must be signed in to change notification settings - Fork 77
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
When the main loop exits, it checks that no uring operations are still in progress. Normally this will be the case because we don't allow a fiber to resume until its operation is complete, and the event loop doesn't exit until all fibers have done so.
However, cancel operations don't stop and wait. So I think this can happen:
- Fiber A starts an operation.
- Fiber B asks to cancel it and finishes.
- Fiber A's operation completes by itself and fiber A finishes.
- We try to end the loop, but get an error because the cancel operation hasn't yet been processed.
I think this is the cause of #466 (comment).
We should probably just wait for cancel operations to complete the same way we do for other operations.
This issue was previously hidden because the exception was reported using Log.warn
, which silently drops messages by default. #465 changed this to raise an exception instead.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working