Clean up configurator code and update primitives.h #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Sep 27, 2025
CHANGES: - Fix use-after-free data race in CQE handlers (@avsm ocaml-multicore/ocaml-uring#124, reported ocaml-multicore/ocaml-uring#123 by @polytypic). - Add socket bind and listen operations (@avsm ocaml-multicore/ocaml-uring#118). - Update liburing to 2.7 (@avsm ocaml-multicore/ocaml-uring#118). - Add `Uring.Setup_flags` module (@talex5 ocaml-multicore/ocaml-uring#122). - Clean up configurator code and update primitives.h (@talex5 ocaml-multicore/ocaml-uring#121). - Add `mkdirat` operation (@patricoferris ocaml-multicore/ocaml-uring#120).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated config.ml should be identical (it is for me), but this should make adding to it a bit easier (which I want to do in the next PR).
(Updating the header needs
lintcstubs-arity, which requires OCaml < 5.2, which is a bit annoying (see edwintorok/lintcstubs-arity#1))