Skip to content

Conversation

jmid
Copy link
Member

@jmid jmid commented May 5, 2025

This is modeled after the initial example PR #26072 from @dra27 (for libssl)
and a more recent one (#27553) for libevent.

@jmid
Copy link
Member Author

jmid commented May 5, 2025

Mumble... 🤔
It seems the MinGW package doesn't include a .pc file for pkgconf to pick up: https://www.cygwin.com/packages/x86_64/mingw64-x86_64-freeglut/mingw64-x86_64-freeglut-2.8.1-1
whereas on MSys it does include a .pc file: https://packages.msys2.org/packages/mingw-w64-x86_64-freeglut

Furthermore, I realize that Linux and FreeBSD query pkg-config glut whereas MSys registers it under the freeglut name.
https://cgit.freebsd.org/ports/tree/graphics/freeglut/pkg-plist

@shonfeder shonfeder marked this pull request as draft May 21, 2025 16:43
@shonfeder
Copy link
Contributor

IIUC, this is still being worked on, so I've marked it accordingly. Please LMK if I'm misinterpreting!

@jmid
Copy link
Member Author

jmid commented May 22, 2025

Digging some more into this, I can see a .pc file was added upstream for the freeglut package in the 3.0.0(-rc1) release: https://github.com/freeglut/freeglut/commits/master/freeglut.pc.in

This also explains why

The MinGW failure is therefore to be expected - and unlikely to change status unless someone steps up and adopts the Cygwin package.

@jmid
Copy link
Member Author

jmid commented May 22, 2025

Based on the above, I've gone with

I've not adjusted the logic to remove the conf-pkg-config dependency on Win32 MinGW while attempting to keep it on Win32 MSys as it seemed overkill.

Finally, seeing the previous CI run failed on macOS I've added entries based on
https://formulae.brew.sh/formula/freeglut and https://ports.macports.org/port/freeglut/details/

@jmid jmid marked this pull request as ready for review May 22, 2025 15:24
@shonfeder
Copy link
Contributor

Fantastic. Thank you for the fixes and for adding this conf- package! 🙏

@shonfeder shonfeder merged commit b847320 into ocaml:master May 22, 2025
3 checks passed
@jmid jmid deleted the conf-freeglut-windows branch May 22, 2025 19:40
mseri added a commit that referenced this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants