-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add MinGW and MSys support for libao #28376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "conf-mingw-w64-gcc-x86_64" {build} | ||
| ] | ||
| depexts: [ | ||
| ["mingw64-x86_64-libao"] {os = "win32" & os-distribution = "cygwin"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While working on my blog post about libao I used exactly this depext entry for cygwin and found that it didn't work properly. The mingw64-x86_64-* package seem to install to \root\usr\x86_64-w64-mingw32\sys-root\mingw\lib, and I found that pkgconf doesn't look in this directory when searching for libraries. I only managed to get this working on msys2 (using the exact same line you have below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you invoke pkgconf with the --personality=x86_64-w64-mingw32 flag like the tests in conf-mingw-w64-ao-x86_64.1/opam and conf-ao.1/opam do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh interesting, no I did not. That might be what I was doing wrong. Let me see if that works for me!
|
I've tested this on my x86_64 windows machine with opam configured to use msys2 and I can build the |
Excellent! 🎉
I've just used the CI workflow, which at the moment only tests MinGW (installed via Cygwin). |
|
I just set up a cygwin-based opam environment and confirmed that I can also build the |
|
I am going to merge. This is a strict improvement over the previous situation. Thanks! |
This PR adds MinGW and MSys support for
libao. It is based onThe PR is modeled after #26072 by @dra27 who wrote (I quote): 😃
Polite ping to @gridbugs who struggled to get this working https://www.gridbugs.org/sound-on-ocaml-on-windows/ and thus may be interested in testing it... 🤞