Monkeypatch out checking for affiliation, as berkeleyEduAffiliations … #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzh-bzh
force-pushed
the
ldap-affil-monkeypatch
branch
from
38ad21e to
02ee742
Compare
abizer
approved these changes
Oct 1, 2018
jvperrin
approved these changes
Oct 1, 2018
There was a problem hiding this comment.
Looks good besides the tests.
I'd also put a TODO comment by each of these to let people know that they should be re-enabled in the future. Generally otherwise, I'd assume commented-out code could be removed, so giving some reason for why it should stay is a good practice.
kkuehlz
approved these changes
Oct 1, 2018
bzh-bzh
force-pushed
the
ldap-affil-monkeypatch
branch
from
02ee742 to
6ea4125
Compare
berkeleyEduAffiliations is being removed from anonymous LDAP searches.
bzh-bzh
force-pushed
the
ldap-affil-monkeypatch
branch
from
f9af792 to
a7f4598
Compare
kpengboy
approved these changes
Oct 1, 2018
| attrs_ucb = user_attrs_ucb(attrs['calnetUid']) | ||
| if attrs_ucb and 'EMPLOYEE-TYPE-ACADEMIC' in attrs_ucb['berkeleyEduAffiliations']: | ||
| # TODO: Uncomment when we get a privileged LDAP bind. | ||
| if attrs_ucb: # and 'EMPLOYEE-TYPE-ACADEMIC' in attrs_ucb['berkeleyEduAffiliations']: |
There was a problem hiding this comment.
This will permit arbitrary members of the OCF to submit vhost requests. You ought to be prepared for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is being removed from anonymous LDAP searches.
please let me know if i missed anything for account creation that uses this attribute