Skip to content

Conversation

@wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Jun 3, 2023

Follow-up to #161

Behavior

Before the change?

  • A browser build was being generated even though this package shouldn't be used in a browser

After the change?

  • Removes the browser build

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 3, 2023
@ollie-iterators
Copy link

Why is this here? #161 was just merged and it has the same title.

@wolfy1339
Copy link
Member Author

@kfcampbell must not have seen that this PR was open.

The difference between the 2 is that this one doesn't add a browser build, as this module shouldn't be used in a browser.
I'll fix up the conflicts and update the PR title accordingly

@wolfy1339 wolfy1339 changed the title fix(build): switch to esbuild fix(build): remove browser build Jun 9, 2023
@wolfy1339 wolfy1339 requested a review from kfcampbell June 9, 2023 19:33
@wolfy1339
Copy link
Member Author

A browser build was not being generated before with Pika

Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfy1339's right; I didn't see this, sorry!

@kfcampbell kfcampbell merged commit a033e04 into main Jun 26, 2023
@kfcampbell kfcampbell deleted the esbuild branch June 26, 2023 21:57
@github-actions
Copy link

🎉 This PR is included in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants