fix: pass on to the next middleware in case of express #534
Conversation
As I explained [here](octokit#509 (comment)), it is now required to always install this middleware to the end of the chain, otherwise it rejects all requests it cannot handle.
honnix
changed the title
honnix
changed the title
|
@gr2m PTAL and help me understand whether this is a valid change. Thanks a lot. |
|
Sorry I couldn't figure out how to add a correct label. I guess this is a |
wolfy1339
added
the
Type: Bug
There was a problem hiding this comment.
This looks great, thank you @honnix 👍🏼 I'm not very familiar with express, if there is anything we can do to make it easier to use for express users, please let us know.
I also made follow up issue to make sure we test the express integration in @octokit/oauth-app and @octokit/app: octokit/app.js#236, octokit/oauth-app.js#222
|
🎉 This PR is included in version 9.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@gr2m Thanks for approving and merging. I cannot say myself familiar with express either but I thinkthe added test cases should help catch similar problem in the future. |
3 participants
As I explained here, it is now required to always install this middleware to the end of the chain, otherwise it rejects all requests it cannot handle.