Update worker.py for compatibility with upstream TVM #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates `mlc_llm.cli.worker` to be compatible with upstream TVM apache/tvm#17180, which adds a `num_groups` argument to the disco worker function. To de-couple this compatibility from a general TVM version bump, this commit has a check on the number of `worker.py` arguments provided, to determine whether the `num_groups` argument is present. After the TVM version used by MLC-LLM is updated to include the upstream changes, this check can be removed.
Author
|
This is equivalent to the upstream PR mlc-ai#2712 |
sunggg
approved these changes
Jul 31, 2024
Lunderberg
deleted the
lunderberg/octo_disco_worker_compatibility_with_tvm17180
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
mlc_llm.cli.workerto be compatible with upstream TVM apache/tvm#17180, which adds anum_groupsargument to the disco worker function.To de-couple this compatibility from a general TVM version bump, this commit has a check on the number of
worker.pyarguments provided, to determine whether thenum_groupsargument is present. After the TVM version used by MLC-LLM is updated to include the upstream changes, this check can be removed.