[IMP] package: use references to build #7352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LucasLefevre
force-pushed
the
master-reference-build-lul
branch
3 times, most recently
from
58b6114 to
b139401
Compare
Import from `@o-spreadsheet-engine` instead of using relative paths across different packages. Task: 5173883
Use `references` to tell that the root packages references `o-spreadsheet-engine` and that it must be build first. https://www.typescriptlang.org/docs/handbook/project-references.html TS uses the generated `.d.ts` files in `o-spreadsheet-engine` when type checking `o-spreadsheet`, instead of resolving all the types for second time. `npm run build`: before: 23s after: 16s Task: 5173883
With this commit, the `serve-static` command in the `dev` script now waits for the `o_spreadsheet.iife.js` build to complete before starting the static server. This ensures that the server serves the latest build files, preventing potential issues with stale content.
pro-odoo
force-pushed
the
master-reference-build-lul
branch
from
4f93889 to
f15b822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use
referencesto tell that the root packages referenceso-spreadsheet-engineand that it must be build first.TS uses the generated
.d.tsfiles ino-spreadsheet-enginewhen type checkingo-spreadsheet, instead of resolving all the types for second time.npm run build:before: 23s
after: 16s
Task: 5173883
review checklist