[IMP] image: do not swallow exception and remove GC #7353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
If the image upload fails, it means there's a problem somewhere that needs to be investiguated. But we are currently try/catching the error to show a user-friendly message. Several issues: - The user doesn't care if the message is friendly or not: he wanted to upload an image and it doesn't work. - the person investiguating the issue wants the full traceback to investiguate efficiently Task: 5176795
This commit removes the image file garbage collection mechanism. Originally, files were deleted when their corresponding images were removed from the spreadsheet. However, this caused the files to become unavailable in the version history and added unnecessary complexity to handle properly. File deletion is now delegated to the integrator software, which is responsible for cleaning up files when needed. Task: 5176795
LucasLefevre
force-pushed
the
master-remove-image-catch-lul
branch
from
210f106 to
df5deb5
Compare
LucasLefevre
changed the title
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Oct 21, 2025
If the image upload fails, it means there's a problem somewhere that needs to be investiguated. But we are currently try/catching the error to show a user-friendly message. Several issues: - The user doesn't care if the message is friendly or not: he wanted to upload an image and it doesn't work. - the person investiguating the issue wants the full traceback to investiguate efficiently Task: 5176795 Part-of: #7353 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Oct 21, 2025
This commit removes the image file garbage collection mechanism. Originally, files were deleted when their corresponding images were removed from the spreadsheet. However, this caused the files to become unavailable in the version history and added unnecessary complexity to handle properly. File deletion is now delegated to the integrator software, which is responsible for cleaning up files when needed. closes #7353 Task: 5176795 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
hokolomopo
pushed a commit
that referenced
this pull request
Oct 23, 2025
This commit removes the image file garbage collection mechanism. Originally, files were deleted when their corresponding images were removed from the spreadsheet. However, this caused the files to become unavailable in the version history and added unnecessary complexity to handle properly. File deletion is now delegated to the integrator software, which is responsible for cleaning up files when needed. closes #7353 Task: 5176795 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit messages
Task: 5176795
review checklist