Skip to content
This repository was archived by the owner on Sep 9, 2021. It is now read-only.

Conversation

mtbc
Copy link
Member

@mtbc mtbc commented May 24, 2016

This new blog entry addresses https://trello.com/c/9YhVKx4U/449-roi-transforms by warning of the breaking changes caused by ome/openmicroscopy#4672.

Albeit with broken formatting one can get a view of the text at https://github.com/mtbc/blog/blob/transforms/_posts/2016-06-15-shape-transforms.md. For proper formatting use Jekyll locally.

@dominikl
Copy link
Member

Looks alright to me! 👍

@mtbc
Copy link
Member Author

mtbc commented May 26, 2016

Thank you @dominikl! Much appreciated, as you also reviewed the corresponding PR. After @sbesson and @hflynn have taken a look I'll copy over to gdoc for @jrswedlow but fine if all that's after PotN.

@sbesson sbesson mentioned this pull request May 26, 2016
element with an
[AffineTransform](https://www.openmicroscopy.org/Schemas/Documentation/Generated/OME-2015-01/ROI_xsd.html#AffineTransform)
type that is used to transform a Shape's position in the image in
various ways: scaling, rotations and more. In order to properly locate a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth including 2D to define the limit of the transformations?

@sbesson
Copy link
Member

sbesson commented May 26, 2016

Couple of thoughts post review:

  • generally on the review process
    • I needed Add pagination for Jekyll upgrade #31 to build this page locally using Jekyll 3.1.6. The pagination gem is explicitly included as a dependency on the GH pages side (see Jekyll 3.0.x github/pages-gem#175). Is it worth reincluding for our own development/review workflow or are there workarounds?
    • I also needed to rename this page to prevent using a future date - I assume it's a blog feature
  • while we mention Java client upgrade, do we have/need to collect more information on OMERO.web?
  • once cleared, I think some of the information in this blog post could also be copied over to the ome.xsd hence the generated Oxygen documentation for the schema and the OMERO developer documentation

@hflynn
Copy link

hflynn commented May 26, 2016

Now I've got this building locally using the same method as Seb, it's looking good thanks! I second the suggestion that we add a link to the developer docs once we publish this. I leave you to decide what action is appropriate re: OMERO.web but from my side, good to be cleared by Jason and then published with an appropriate date change.

@hflynn
Copy link

hflynn commented May 26, 2016

P.S. have merged the pagination gem addition so everyone with the latest version of jekyll will be able to build locally once they fetch the update.

@mtbc
Copy link
Member Author

mtbc commented May 26, 2016

OMERO.web: from my impression of the Python and JavaScript code I'm also fairly optimistic about it: I think it's already using matrices of a corresponding form. I just mentioned the Java as an example to show that the speculation is founded!

@mtbc
Copy link
Member Author

mtbc commented May 26, 2016

I hadn't realized the local staging issues, my apologies for that trouble. To allow people to avoid Jekyll issues entirely I've now staged the blog myself: for this PR see http://users.openmicroscopy.org.uk/~mtbcarroll/vpn/blog/data-model/future-plans/2016/06/15/shape-transforms/. @sbesson: You'll need to VPN to see it.

@hflynn
Copy link

hflynn commented Jun 16, 2016

@mtbc when you get chance, can you update the filename date to 2016-06-20 and then I'll get this out next week

@mtbc
Copy link
Member Author

mtbc commented Jun 16, 2016

Will do so later today.

@hflynn hflynn merged commit 3cbd819 into ome:gh-pages Jun 20, 2016
@mtbc mtbc deleted the transforms branch June 21, 2016 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants