Update oauth.rb for compatibility with rack v3.1+ #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnet
added a commit
to willnet/omniauth-oauth
that referenced
this pull request
Jun 27, 2024
|
resolved in #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line causes logins to fail in rack v3.1+
https://github.com/omniauth/omniauth-oauth/blob/master/lib/omniauth/strategies/oauth.rb#L51
It must be changed from
opts[:oauth_verifier] = request["oauth_verifier"]to
opts[:oauth_verifier] = request.params["oauth_verifier"]Due to my Rails app's state, I was only able to test
request.params["oauth_verifier"]going back to rack v2.2.4 where it continued to be functional.Let me know if you'd prefer something like
Gem.loaded_specs["rack"].version >= Gem::Version.new("3.0")to conditionally switch to the updated syntax.