Skip to content

Conversation

@ldorau
Copy link
Contributor

@ldorau ldorau commented May 12, 2025

Description

Add assert in the ConcurrentDestroyIpcHandlers test.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner May 12, 2025 09:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an assertion to the ConcurrentDestroyIpcHandlers test to verify that each pool created by makePool() is not a nullptr.

  • Added ASSERT_NE check for each pool in the consumerPools vector.
Comments suppressed due to low confidence (1)

test/ipcFixtures.hpp:724

  • Consider storing the result of makePool() in a temporary variable and asserting it immediately before pushing it into the vector. This minor refactor can improve clarity and isolate the test for pool creation.
ASSERT_NE(consumerPools[i].get(), nullptr);

@lukaszstolarczuk lukaszstolarczuk merged commit 14a8d70 into oneapi-src:main May 12, 2025
251 of 254 checks passed
@ldorau ldorau deleted the Add_assert_in_the_ConcurrentDestroyIpcHandlers_test branch May 13, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants