Skip to content

Conversation

blenderfreaky
Copy link
Contributor

This fixes the issue described in #1474

Description

The CMake code causing the issue now checks whether it's using ninja. If it is, it manually escapes the $ that it fails to escape on its own.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly

@blenderfreaky blenderfreaky requested a review from a team as a code owner August 5, 2025 04:14
@blenderfreaky blenderfreaky changed the base branch from main to v1.0.x August 5, 2025 04:15
@bratpiorka
Copy link
Contributor

@blenderfreaky UMF uses automatic code format checks, which are failing with your code. Note that the cmake-format package needs to be installed on your system

python -m pip install cmake-format==0.6.13

cmake --build build (...) -DUMF_FORMAT_CODE_STYLE=ON
cmake --build build --target cmake-format-apply

@blenderfreaky
Copy link
Contributor Author

@bratpiorka thanks for the help! Rebased to fix the formatting issue

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@lukaszstolarczuk lukaszstolarczuk merged commit e9fdf33 into oneapi-src:v1.0.x Aug 6, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants