use fileline in logs in developer mode instead of funcion name #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you show me what an example log would look like in dev mode after your changes? |
with pleasure This is how now one can work with L0 logs inside IDE: |
bratpiorka
reviewed
Sep 22, 2025
src/utils/utils_log.h
Outdated
| #ifdef UMF_DEVELOPER_MODE | ||
| #define UMF_STRINGIFY(x) #x | ||
| #define UMF_TOSTRING(x) UMF_STRINGIFY(x) | ||
| #define UMF_FUNC_DESC() __FILE__ ":" UMF_TOSTRING(__LINE__) |
There was a problem hiding this comment.
could you change this to "file: line (func)" or sth similar that looks ok? I mean I would still like to know the name of the function from which the log was printed
There was a problem hiding this comment.
please show me what the current log looks like
There was a problem hiding this comment.
please show me what the current log looks like
[DEBUG UMF] /home/lucasso/src/unified-memory-framework/src/libumf.c:82 umfInit: UMF tracker created
[DEBUG UMF] /home/lucasso/src/unified-memory-framework/src/libumf.c:92 umfInit: UMF IPC cache initialized
[DEBUG UMF] /home/lucasso/src/unified-memory-framework/src/libumf.c:99 umfInit: UMF library initialized
bratpiorka
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.