Implement umfPool[Set/Get]Tag #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
approved these changes
Dec 5, 2024
|
@igchor do we need this for 0.10x / 2025.1? |
vinser52
approved these changes
Dec 5, 2024
lplewa
reviewed
Dec 5, 2024
include/umf/memory_pool.h
Outdated
| /// @brief Set a custom tag on the memory pool that can be later retrieved using umfPoolGetTag. | ||
| /// @param hPool specified memory pool | ||
| /// @param tag tag to be set | ||
| /// @param oldTag [out] previous tag set on the memory pool |
There was a problem hiding this comment.
document that it's optional and can be null
No, for now I only want to use it for v2 L0 adapter which will not be released as part of 2025.1 |
bratpiorka
approved these changes
Dec 5, 2024
Implements oneapi-src#687
lukaszstolarczuk
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #687
Description
Checklist