Skip to content

add fixed provider #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

add fixed provider #976

merged 1 commit into from
Dec 16, 2024

Conversation

lplewa
Copy link
Contributor

@lplewa lplewa commented Dec 6, 2024

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@lplewa lplewa requested a review from a team as a code owner December 6, 2024 14:56
bratpiorka
bratpiorka reviewed Dec 7, 2024
View reviewed changes
PatKamin
PatKamin reviewed Dec 9, 2024
View reviewed changes
vinser52
vinser52 reviewed Dec 9, 2024
View reviewed changes
ldorau
ldorau reviewed Dec 9, 2024
View reviewed changes
ldorau
ldorau requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR depends on #981 and should be merged after it.

After having applied the requested changes the tests starts to fail and they should be fixed accordingly.

@ldorau ldorau mentioned this pull request Dec 10, 2024
Merged
3 tasks
@ldorau
Copy link
Contributor

ldorau commented Dec 10, 2024

#981 has been merged. Rebase please.

lukaszstolarczuk
lukaszstolarczuk reviewed Dec 11, 2024
View reviewed changes
bratpiorka
bratpiorka reviewed Dec 11, 2024
View reviewed changes
src/libumf.def
umfFileMemoryProviderParamsSetPath
umfFileMemoryProviderParamsSetProtection
umfFileMemoryProviderParamsSetVisibility
umfFixedMemoryProviderOps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add new functions to LIBUMF_0.11 set (requires #974 merged + rebase)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it will be merged....

@lplewa lplewa force-pushed the fixed branch 4 times, most recently from e9f92ca to 4e91bc9 Compare December 12, 2024 13:48
PatKamin
PatKamin reviewed Dec 13, 2024
View reviewed changes
@lukaszstolarczuk lukaszstolarczuk merged commit 95861f3 into oneapi-src:main Dec 16, 2024
77 checks passed
@bratpiorka bratpiorka mentioned this pull request Jan 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinser52 vinser52 vinser52 left review comments

@ldorau ldorau ldorau approved these changes

@bratpiorka bratpiorka bratpiorka left review comments

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk left review comments

@PatKamin PatKamin PatKamin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lplewa @ldorau @vinser52 @bratpiorka @lukaszstolarczuk @PatKamin