Skip to content

Codespell #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2024
Merged

Codespell #994

merged 2 commits into from
Dec 19, 2024

Conversation

luszczewskakasia1
Copy link
Contributor

@luszczewskakasia1 luszczewskakasia1 commented Dec 12, 2024 •
edited by ldorau
Loading

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@luszczewskakasia1 luszczewskakasia1 requested a review from a team as a code owner December 12, 2024 12:51
@luszczewskakasia1 luszczewskakasia1 mentioned this pull request Dec 12, 2024
Closed
10 tasks
lukaszstolarczuk
lukaszstolarczuk reviewed Dec 12, 2024
View reviewed changes
PatKamin
PatKamin reviewed Dec 13, 2024
View reviewed changes
PatKamin
PatKamin reviewed Dec 13, 2024
View reviewed changes
@luszczewskakasia1 luszczewskakasia1 force-pushed the codespell branch 2 times, most recently from b2536bf to 31715a3 Compare December 17, 2024 15:01
ldorau
ldorau reviewed Dec 17, 2024
View reviewed changes
ldorau
ldorau requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Run codespell step does not fail if codespell finds errors:
https://github.com/ldorau/unified-memory-framework/actions/runs/12388725376/job/34580341701

ldorau
ldorau requested changes Dec 18, 2024
View reviewed changes
PatKamin
PatKamin reviewed Dec 18, 2024
View reviewed changes
PatKamin
PatKamin reviewed Dec 18, 2024
View reviewed changes
PatKamin
PatKamin reviewed Dec 18, 2024
View reviewed changes
@ldorau
Copy link
Contributor

ldorau commented Dec 18, 2024

@lukaszstolarczuk @PatKamin re-review please

lukaszstolarczuk
lukaszstolarczuk reviewed Dec 19, 2024
View reviewed changes
@luszczewskakasia1
add python script to run codespell scan
f70c7ca 
Signed-off-by: Katarzyna Luszczewska <[email protected]>
lukaszstolarczuk
lukaszstolarczuk approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! LGTM

@lukaszstolarczuk lukaszstolarczuk merged commit 88bb108 into oneapi-src:main Dec 19, 2024
23 of 64 checks passed
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Dec 30, 2024
Closed
@luszczewskakasia1 luszczewskakasia1 deleted the codespell branch January 28, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldorau ldorau ldorau approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@PatKamin PatKamin PatKamin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luszczewskakasia1 @ldorau @lukaszstolarczuk @PatKamin