Skip to content

Conversation

@EwanC
Copy link
Contributor

@EwanC EwanC commented Feb 12, 2025

Same patch as #2606 which was reverted due to intel/llvm#16982

The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated changes to adapters and CTS.

DPC++ PR intel/llvm#16984
Closes #2600

@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues native-cpu Native CPU adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Feb 12, 2025
**Same patch as oneapi-src#2606
which was reverted due to intel/llvm#16982

The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated changes to adapters and CTS.

Closes oneapi-src#2600
@EwanC EwanC force-pushed the ewan/rename_enqueue branch from fbe39fd to 0938387 Compare February 18, 2025 15:21
@EwanC
Copy link
Contributor Author

EwanC commented Feb 19, 2025

Closing this, as after the UR repo move all the changes are bundled into intel/llvm#16984

@EwanC EwanC closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command-buffer Command Buffer feature addition/changes/specification conformance Conformance test suite issues. cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues specification Changes or additions to the specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp

1 participant