Skip to content

Conversation

pvchupin
Copy link
Contributor

If other project (e.g. DPC++) is trying to fetch unified_runtime repo it fails due to cmake errors. In DPC++ we currently need includes only so actuall content of these files doesn't matter today.

If other project (e.g. DPC++) is trying to fetch unified_runtime repo it fails
due to cmake errors. In DPC++ we currently need includes only so
actuall content of these files doesn't matter today.
@FranklandJack
Copy link
Contributor

FranklandJack commented Nov 21, 2022

Is there no way to fix this downstream in the DPC++ repo?

If the files just need to exist but don't actually need to have anything in them it seems like this could be a bug in the upstream CMake, or the downstream repo could create these files on the fly as part of the build?

Adding files to this repo to fix the build of downstream repos seems like reversing the dependency relationship to me.

@kbenzie
Copy link
Contributor

kbenzie commented Nov 21, 2022

@pvchupin if you could provide a link to where this is causing issues I'd appreciate that.

The CMakeLists.txt as they are now don't really follow best practices for use with FetchContent so I've created #30 to address that.

@pvchupin
Copy link
Contributor Author

pvchupin commented Nov 21, 2022

@FranklandJack, @kbenzie, to reproduce that you need another project (or just have another CMakeLists.txt) to do a FetchContent for this project. Like here: https://github.com/intel/llvm/pull/7293/files#diff-1bf2ed05c0065126d4e2150f0eda4dbd561e5c3625452e96356aadafa1312e6fR9-R20

This needs to be fixed in unified-runtime project, because currently makefiles are corrupted. In particular there are 2 problems to fix:

This PR adds missing files (assuming they will appear at some point in the future). Alternatively corresponding lines could be removed.

@kbenzie
Copy link
Contributor

kbenzie commented Nov 22, 2022

Thanks @pvchupin. I think I have a good idea of how properly resolve this moving forwards but think we can merge this now to unblock work on DPC++.

@kbenzie kbenzie merged commit fd711c9 into oneapi-src:main Nov 22, 2022
@pvchupin pvchupin deleted the fetch branch November 22, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants