Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Conversation

@jribbink
Copy link
Contributor

@jribbink jribbink commented Jun 22, 2022

Closes #113

@jribbink jribbink requested a review from a team as a code owner June 22, 2022 06:14
@jribbink jribbink self-assigned this Jun 22, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022

🦋 Changeset detected

Latest commit: 2d3668b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
flow-js-testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jribbink jribbink changed the title Dynamically select emulator ports from machine instead of static ports specified by user or defaults [DEPENDS ON #116] Dynamically select emulator ports from machine instead of static ports specified by user or defaults Jun 22, 2022
@jribbink jribbink marked this pull request as draft June 22, 2022 16:42
@jribbink jribbink changed the title [DEPENDS ON #116] Dynamically select emulator ports from machine instead of static ports specified by user or defaults Dynamically select emulator ports from machine instead of static ports specified by user or defaults Jun 23, 2022
…le ports in order to abstract user away from concept of emulator ports prevent any sort of overlap with already running emulator.
@jribbink jribbink force-pushed the jribbink/auto-select-port branch from a53752b to 55233d4 Compare June 23, 2022 18:47
@jribbink jribbink marked this pull request as ready for review June 28, 2022 22:12
@jribbink jribbink requested a review from gregsantos June 28, 2022 22:12
@jribbink jribbink marked this pull request as draft June 28, 2022 22:17
@jribbink jribbink force-pushed the jribbink/auto-select-port branch from febc21c to e990f08 Compare June 28, 2022 22:37
@jribbink jribbink marked this pull request as ready for review June 28, 2022 22:38
Copy link

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should prob clean up the README and docs/emulator.md reflect these changes and clarify how/if emulator should be started

@jribbink jribbink requested a review from gregsantos June 30, 2022 21:29
Copy link

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g2g

@jribbink jribbink merged commit 033562b into master Jun 30, 2022
This was referenced Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emulator ports should not be static

3 participants