This repository was archived by the owner on Nov 5, 2024. It is now read-only.
Convert examples to Jest instead of using ESM loader #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 72a18b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jribbink
force-pushed
the
jribbink/fix-examples
branch
from
7d1cd81 to
f733319
Compare
jribbink
force-pushed
the
jribbink/fix-examples
branch
from
e5764ff to
08d70b9
Compare
jribbink
force-pushed
the
jribbink/fix-examples
branch
from
08d70b9 to
6c40b09
Compare
gregsantos
approved these changes
Jul 14, 2022
gregsantos
left a comment
gregsantos
left a comment
There was a problem hiding this comment.
LG2M, but do we want all those logs?
Contributor
Author
It was intentional so that the user could maybe see what was going on during the examples. I'm open to nixing them though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143