Allow for custom transaction signers to be provided

[jribbink]

Closes #154

Description

• Allows signers to be provided as either an address (like before) or an object including any of the following properties: addr, privateKey, hashAlgorithm, keyId
• Fixes dev-tests (were not being used by jest config previously)
• Adds new dev-tests for signers provided as object
• Adds documentation to sendTransaction

---

For contributor use:

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[changeset-bot]

🦋 Changeset detected

Latest commit: e3d32f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@onflow/flow-js-testing	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gregsantos]

It shall be approved

[tav]

Thanks for the super fast turnaround!

Unfortunately, there seems to be some confusion around the cryptographic terminology:

• hashAlgorithm refers to one of the supported hash algorithms, i.e. SHA2_256, SHA2_384, SHA3_256, SHA3_384, KMAC128_BLS_BLS12_381, and KECCAK_256.

• keyType or signingAlgorithm refers to one of the supported signing algorithms, i.e. ECDSA_P256, ECDSA_secp256k1, and BLS_BLS12_381.

That is, what this PR has called hashAlgorithm, should actually be something like keyType or signingAlgorithm, and there should be a separate hashAlgorithm field which results in the right hashing function being used.

[jribbink]

Thanks for the super fast turnaround!

Unfortunately, there seems to be some confusion around the cryptographic terminology:

• hashAlgorithm refers to one of the supported hash algorithms, i.e. SHA2_256, SHA2_384, SHA3_256, SHA3_384, KMAC128_BLS_BLS12_381, and KECCAK_256.
• keyType or signingAlgorithm refers to one of the supported signing algorithms, i.e. ECDSA_P256, ECDSA_secp256k1, and BLS_BLS12_381.

That is, what this PR has called hashAlgorithm, should actually be something like keyType or signingAlgorithm, and there should be a separate hashAlgorithm field which results in the right hashing function being used.

Apologies, this was my mistake and I will try to make a revised PR ASAP. Thank you for the clarification.

[tav]

Thanks @jribbink — any chance you could also do an npm publish too please?

[jribbink]

Thanks @jribbink — any chance you could also do an npm publish too please?

Will do - the package has been moved from https://www.npmjs.com/package/flow-js-testing to https://www.npmjs.com/package/@onflow/flow-js-testing, so the published package will appear in this new registry.

[tav]

Ah, didn't catch the move — thanks @jribbink!