Skip to content

Conversation

@JunyaoHu
Copy link

Motivation

超级视客营 mmdet 基础任务,为part-9的 bfp.pychannel_mapper.py 添加 type hints

Modification

  1. 昨天修改好了 bfp.py 并提交PR且已经过审,但不太熟悉PR操作,没有签署 commit sign 导致无法合并
  2. channel_mapper.py 中相关函数添加 type hints

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@JunyaoHu JunyaoHu changed the title [Fix] add type hints for bfp and channel_mapper CodeCamp #9 add type hints for bfp and channel_mapper Dec 1, 2022
@JunyaoHu JunyaoHu changed the title CodeCamp #9 add type hints for bfp and channel_mapper CodeCamp #34 add type hints for bfp and channel_mapper Dec 1, 2022
@BIGWangYuDong
Copy link
Collaborator

LGTM

@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Dec 2, 2022
@ZwwWayne ZwwWayne requested a review from RangiLyu December 7, 2022 02:33
@JunyaoHu JunyaoHu closed this Dec 7, 2022
@JunyaoHu JunyaoHu reopened this Dec 7, 2022
@JunyaoHu JunyaoHu closed this Dec 7, 2022
@JunyaoHu JunyaoHu reopened this Dec 7, 2022
@ZwwWayne ZwwWayne merged commit e10dd16 into open-mmlab:dev-3.x Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants