Skip to content

Conversation

@nijkah
Copy link
Contributor

@nijkah nijkah commented Feb 9, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

rand_sign # [low, high), 1 or -1, randomly

# calculate the random part of the added noise
rand_part = torch.rand_like(gt_bboxes_expand) # [0, 1)
rand_part[negative_idx] += 1.0 # pos: [0, 1); neg: [1, 2)
rand_part *= rand_sign # pos: (-1, 1); neg: (-2, 1] U [1, 2)

Current code is written as neg: (-2, 1] U [1, 2), but it is actually neg: (-2, -1] U [1, 2).

image

(Fig.3. of the original paper)

Modification

Fix neg: (-2, 1] U [1, 2) to neg: (-2, -1] U [1, 2).

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@jshilong jshilong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Li-Qingyun
Copy link
Contributor

@nijkah Good catch! Thanks for your pr!

@ZwwWayne ZwwWayne merged commit 3446bd1 into open-mmlab:dev-3.x Feb 9, 2023
@nijkah nijkah deleted the fix/docstring branch February 9, 2023 14:11
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants