Skip to content

[Feature] Fully support DiffusionDet in projects #9768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 21, 2023
Merged

[Feature] Fully support DiffusionDet in projects #9768

merged 7 commits into from
Feb 21, 2023

Conversation

@BIGWangYuDong
Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong commented Feb 14, 2023

No description provided.

@BIGWangYuDong BIGWangYuDong changed the title [WIP][Feature] Fully support DiffusionDet [Feature] Fully support DiffusionDet in projects Feb 20, 2023
@BIGWangYuDong BIGWangYuDong marked this pull request as ready for review February 20, 2023 06:44
RangiLyu
RangiLyu reviewed Feb 20, 2023
View reviewed changes
RangiLyu
RangiLyu reviewed Feb 20, 2023
View reviewed changes
@Li-Qingyun
Copy link
Contributor

Li-Qingyun commented Feb 20, 2023

图片
Hi~, It seems that we should use AspectRatioBatchSampler?

@BIGWangYuDong
Copy link
Collaborator Author

BIGWangYuDong commented Feb 20, 2023 •
edited
Loading

Hi~, It seems that we should use AspectRatioBatchSampler?

Hi @Li-Qingyun,
you can find a setting in base/datasets/cocodetection.py:

batch_sampler=dict(type='AspectRatioBatchSampler'),

@Li-Qingyun
Copy link
Contributor

Li-Qingyun commented Feb 21, 2023

Okkkk, Thanks for your reply~ @BIGWangYuDong

@ZwwWayne ZwwWayne merged commit 659f7a6 into open-mmlab:dev-3.x Feb 21, 2023
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
@BIGWangYuDong @yumion
[Feature] Fully support DiffusionDet in projects (open-mmlab#9768)
28aff02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RangiLyu RangiLyu RangiLyu approved these changes

@Li-Qingyun Li-Qingyun Awaiting requested review from Li-Qingyun

Assignees

@hhaAndroid hhaAndroid

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BIGWangYuDong @Li-Qingyun @RangiLyu @hhaAndroid @ZwwWayne