Skip to content

Conversation

StevenGood154
Copy link
Contributor

@StevenGood154 StevenGood154 commented May 11, 2021

The check_cherry_pick() function in .github/workflows/git-commit-checks.py
would incorrectly allow some cherry-pick messages referring to commits that
do not exist in the base repository, specifically when the commit exists only
on a pull request that has not been merged. This has been resolved; the
workflow will exit with a failure unless the referenced commit exists in
the base repository.

Note that this approach only works because all commits are introduced to
the open-mpi/ompi through pull requests from forks.

Signed-off-by: Steven Good [email protected]
Signed-off-by: Brett Wiseman [email protected]
Signed-off-by: Christine Van Kirk [email protected]
(cherry picked from commit a641680)

The check_cherry_pick() function in .github/workflows/git-commit-checks.py
would incorrectly allow some cherry-pick messages reffering to commits that
do not exist in the base repository, specifially when the commit exists only
on a pull request that has not been merged. This has been resolved; the
workflow will exit with a failure unless the referenced commit exists in
the base repository.

Note that this approach only works because all commits are introduced to
the open-mpi/ompi through pull requests from forks.

Signed-off-by: Steven Good <[email protected]>
Signed-off-by: Brett Wiseman <[email protected]>
Signed-off-by: Christine Van Kirk <[email protected]>
(cherry picked from commit a641680)
@ompiteam-bot
Copy link

Can one of the admins verify this patch?

@jsquyres jsquyres changed the title CI: Fix a bug in the cherry pick checker v3.0.x: CI: Fix a bug in the cherry pick checker May 11, 2021
@jsquyres jsquyres added this to the v3.0.7 milestone May 11, 2021
@jsquyres
Copy link
Member

Corresponding master PR: #8947.
ok to test

@jsquyres jsquyres requested review from bwbarrett and jsquyres and removed request for bwbarrett May 11, 2021 14:04
@jsquyres jsquyres merged commit 5d00daa into open-mpi:v3.0.x May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants