Skip to content

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Jul 12, 2024

Contributes to #2054

Changes

Please provide a brief description of the changes here.

  • completed cleanup of api/include
  • completed cleanup of api/test
  • total number of warnings decreased from 142 in branch main, to 90 in this PR.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (497eaf4) to head (f50ab87).
Report is 121 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3004      +/-   ##
==========================================
+ Coverage   87.12%   87.63%   +0.52%     
==========================================
  Files         200      190      -10     
  Lines        6109     5868     -241     
==========================================
- Hits         5322     5142     -180     
+ Misses        787      726      -61     
Files Coverage Δ
...telemetry/baggage/propagation/baggage_propagator.h 100.00% <ø> (ø)
...ude/opentelemetry/common/key_value_iterable_view.h 94.45% <ø> (ø)
api/include/opentelemetry/context/context.h 100.00% <ø> (ø)
...pi/include/opentelemetry/context/runtime_context.h 97.50% <ø> (-0.09%) ⬇️
api/include/opentelemetry/nostd/function_ref.h 77.78% <ø> (+0.51%) ⬆️
api/include/opentelemetry/nostd/string_view.h 98.08% <ø> (+0.12%) ⬆️
api/include/opentelemetry/nostd/variant.h 66.67% <ø> (ø)
api/include/opentelemetry/trace/noop.h 93.34% <ø> (ø)
api/include/opentelemetry/trace/provider.h 100.00% <ø> (ø)
api/include/opentelemetry/trace/scope.h 100.00% <ø> (ø)
... and 2 more

... and 118 files with indirect coverage changes

@marcalff marcalff marked this pull request as ready for review August 24, 2024 23:06
@marcalff marcalff requested a review from a team August 24, 2024 23:06
@marcalff marcalff added the pr:please-review This PR is ready for review label Aug 24, 2024
@marcalff marcalff changed the title [Code health] include-what-you-use cleanup, part 3 [Code Health] include-what-you-use cleanup, part 3 Aug 24, 2024
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@ThomsonTan ThomsonTan merged commit a920898 into open-telemetry:main Aug 26, 2024
@marcalff marcalff deleted the fix_iwyu_cleanup_3 branch February 5, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants