Skip to content

[TEST] Disable test BasicCurlHttpTests.SendGetRequestAsync #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2025
Merged

[TEST] Disable test BasicCurlHttpTests.SendGetRequestAsync #3722

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
515d5cf
[TEST] Disable test BasicCurlHttpTests.SendGetRequestAsync
marcalff Oct 27, 2025
ab26468
Merge branch 'main' into disable_unstable_test
ThomsonTan Oct 27, 2025
35b17d1
Merge branch 'main' into disable_unstable_test
marcalff Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ext/test/http/curl_http_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,9 @@ class BasicCurlHttpTests : public ::testing::Test, public HTTP_SERVER_NS::HttpRe
}
};

class DISABLED_BasicCurlHttpTests : public BasicCurlHttpTests
{};

TEST_F(BasicCurlHttpTests, DoNothing) {}

TEST_F(BasicCurlHttpTests, HttpRequest)
Expand Down Expand Up @@ -495,7 +498,8 @@ TEST_F(BasicCurlHttpTests, GetBaseUri)
"http://127.0.0.1:31339/");
}

TEST_F(BasicCurlHttpTests, SendGetRequestAsync)
// DISABLED, see https://github.com/open-telemetry/opentelemetry-cpp/issues/3535
TEST_F(DISABLED_BasicCurlHttpTests, SendGetRequestAsync)
{
curl::HttpClient http_client;

Expand Down Expand Up @@ -528,6 +532,8 @@ TEST_F(BasicCurlHttpTests, SendGetRequestAsync)
ASSERT_FALSE(sessions[i]->IsSessionActive());

ASSERT_TRUE(handlers[i]->is_called_.load(std::memory_order_acquire));

// TODO: Spurious test failures here.
ASSERT_TRUE(handlers[i]->got_response_.load(std::memory_order_acquire));
}

Expand Down
Loading