[Exporter.OpenTelemetryProtocol] Remove PeerServiceResolver from compilation #6032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
rajkumar-rangaraj
approved these changes
Dec 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6032 +/- ##
=======================================
Coverage 86.40% 86.40%
=======================================
Files 257 257
Lines 11693 11693
=======================================
Hits 10103 10103
Misses 1590 1590 |
|
CI failures seem related to some change in |
|
@CodeBlanch, thanks for investigation! |
CodeBlanch
deleted the
otlp-remove-PeerServiceResolver-from-compilation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #6005
Changes
[Exporter.OpenTelemetryProtocol] Remove PeerServiceResolver from compilation
Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)