Skip to content

feat(opentelemetry-configuration): creation of basic ConfigProvider #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Jul 24, 2025

Part of #5626

  • Creates a basic configuration object with a few attributes. This object is based on configuration spec names and definitions 1. Following PRs will add more attributes
  • Creates a ConfigProvider, that currently only initialize based on environment variables. This will be the component that will also be able to initialize based on a config file in a future PR
  • README is currently very basic, once more concrete functionality is creates, it will get updates
  • Because we will eventually get rid of the core package, I didn't want to create any dependency on it, but I required a few functions related to configuration that were on them, so I copied those files (environment and diagLogLevel), so we can eventually remove them from core and have everything configuration related in the same package
  • Note: the root package.json has a big diff, looks like it updated a bunch of things with my pr, but I don't know how to get rid of those changes, looking for guidance here

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.01%. Comparing base (48538b4) to head (6eb5c13).

Files with missing lines Patch % Lines
...ntelemetry-configuration/src/utils/diagLogLevel.ts 72.72% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5809   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         303      307    +4     
  Lines        7943     8009   +66     
  Branches     1607     1620   +13     
=======================================
+ Hits         7547     7610   +63     
- Misses        396      399    +3     
Files with missing lines Coverage Δ
.../opentelemetry-configuration/src/ConfigProvider.ts 100.00% <100.00%> (ø)
...packages/opentelemetry-configuration/src/config.ts 100.00% <100.00%> (ø)
...entelemetry-configuration/src/utils/environment.ts 100.00% <100.00%> (ø)
...ntelemetry-configuration/src/utils/diagLogLevel.ts 72.72% <72.72%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag maryliag marked this pull request as ready for review July 25, 2025 14:10
@maryliag maryliag requested a review from a team as a code owner July 25, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant