Skip to content

Conversation

@waynexia
Copy link
Contributor

Fixes #
Design discussion issue (if applicable) #

Changes

This patch bumps tonic and tonic-build to 0.10, prost to 0.12

Related to #1252

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@waynexia waynexia requested a review from a team October 20, 2023 03:13
@waynexia
Copy link
Contributor Author

I have some compiling issues on the entire workspace. Thus I only run checks for opentelemetry-proto:

~/repo/opentelemetry-rust on bump-tonic-prost !1 
❯ cargo check -p opentelemetry-proto            
    Finished dev [unoptimized + debuginfo] target(s) in 0.07s

~/repo/opentelemetry-rust on bump-tonic-prost !1 
❯ cargo clippy -p opentelemetry-proto           
    Finished dev [unoptimized + debuginfo] target(s) in 0.07s

Maybe there are other errors can't be reported

@waynexia
Copy link
Contributor Author

Well, I guess my compile error is caused by tikv/grpc-rs#618. But when I tried to bump grpcio to 0.13 I found it still dependents on prost 0.11....

@cijothomas
Copy link
Member

closing in favor of #1536

@cijothomas cijothomas closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants