Skip to content

Conversation

@edef1c
Copy link

@edef1c edef1c commented Dec 29, 2023

Fix #1458

Changes

This upgrades tonic to 0.10, and upgrades the prost version to match tonic's version, so that relevant traits are actually implemented for the prost version we use.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@edef1c edef1c requested a review from a team December 29, 2023 18:33
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 29, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: edef1c / name: edef (e02a689)

@edef1c
Copy link
Author

edef1c commented Dec 29, 2023

AFAICT this is all blocked on tikv/grpc-rs#636.

@edef1c edef1c marked this pull request as draft December 29, 2023 19:27
@flokli
Copy link

flokli commented Jan 1, 2024

Is this a dup of #1252?

@flokli flokli mentioned this pull request Jan 1, 2024
4 tasks
@hdost
Copy link
Contributor

hdost commented Jan 9, 2024

Recently there was #1457 if you want to try rebasing on main then I think you could move forward.

@0x0blu
Copy link

0x0blu commented Feb 8, 2024

tonic 0.11 is already released.

@cijothomas
Copy link
Member

Closing in favor of #1536

@cijothomas cijothomas closed this Feb 16, 2024
@edef1c edef1c deleted the tonic-0.10 branch May 2, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: update tonic dependency to 0.10.x

5 participants