fix: render channel before recipient #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as according to docs https://cookbook.openai.com/articles/openai-harmony#handling-tool-calls empirically this is also what the model outputs
jordan-wu-97
force-pushed
the
jordan/channel-before-recipient
branch
from
1bd1620 to
f573ab5
Compare
Contributor
Author
|
hmm seems like that breaks the tool call response's format... |
Collaborator
|
This is also intended behavior. The model can generate either order and we normalize here. This is called out in the harmony article as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as according to docs
https://cookbook.openai.com/articles/openai-harmony#handling-tool-calls
empirically this is also what the model outputs