Skip to content

refactor: remove inherited method from Agent class #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

refactor: remove inherited method from Agent class #1267

merged 2 commits into from
Jul 28, 2025
+0 −27

Conversation

windsornguyen
Copy link
Contributor

Brief

This PR removes the get_mcp_tools method from the Agent class to reduce code duplication.

Motivation

The Agent class inherits from AgentBase and therefore already has access to the get_mcp_tools method through inheritance.

@windsornguyen
Copy link
Contributor Author

Ditto for the get_all_tools method. See commit 23c2865.

seratch
seratch approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seratch seratch merged commit 75065ba into openai:main Jul 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

Assignees
No one assigned
Labels
feature:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@windsornguyen @seratch