Skip to content

Conversation

opatut
Copy link
Member

@opatut opatut commented Mar 12, 2023

This branch contains a lot of new features that I've been working on but never finished, for some reason or another. I wanted to get this all out and cleaned up so I can start working on other exciting stuff without all that baggage ;)

Features:

@gluap
Copy link
Contributor

gluap commented Mar 12, 2023

trying to upgrade the db alembic tells me that there are multiple had revisions - and it's right:

both add_user_display_name and create_table_region are the head. (they point to the same prior revision as down_revision).
My bad, wrong branch

@opatut
Copy link
Member Author

opatut commented Mar 21, 2023

So @gluap did you test these changes yet? I'd love some feedback.

@gluap
Copy link
Contributor

gluap commented Mar 21, 2023

@opatut yes.

  • I love the new tracks list, much cleaner and concise than the old one.
  • This update will require a reimport of the geodata.
  • This update will require recomputing all tracks to extract the device IDs.
  • I don't know why but the administrative areas perform better than on my retrofitted version of the branch.
  • I removed the sonarcloud complaints by fixing them / nodding about the log injection alert.

@gluap gluap linked an issue May 19, 2023 that may be closed by this pull request
@gluap
Copy link
Contributor

gluap commented May 19, 2023

I just noticed that we have lost the ".env" file from the deployment/examples in this branch.

@gluap gluap linked an issue May 19, 2023 that may be closed by this pull request
@gluap gluap linked an issue May 19, 2023 that may be closed by this pull request
@gluap gluap mentioned this pull request May 19, 2023
@gluap gluap linked an issue May 19, 2023 that may be closed by this pull request
gluap and others added 7 commits May 25, 2023 21:51
- rename road_usage -> segments (as we're actually dealing with segments not with roads)
- use "select as" to ensure defined behaviour
- cleanup
…usage

Add export of road usage after review (without temporal filtering)
@gluap gluap linked an issue Jun 10, 2023 that may be closed by this pull request
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 47 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gluap gluap merged commit 14c7f6e into main Jun 22, 2023
@gluap gluap deleted the next branch June 22, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants