Correct EIP-712 encoding

[seunlanlege]

Previously when building a type hash for a given struct, the build_dependencies function was unaware that structs could have fields that are arrays of custom types e.g

struct Person {
    address[] wallets
    string name
}

struct Group {
    string name
    Person[] members
}

so when it tried to encode the Group type it produced an incorrect encoding

Group(string name, Person[] members)

instead of:

Group(string name, Person[] members)Person(string name, address[] wallets)

which caused: #11087

this PR addresses this issue and closes #11087

[dvdplm]

Looks close to the JS impl, which is good.

Unrelated q: this crate uses lunarity 0.1. Is there a point in upgrading to 0.2?

[seunlanlege]

Unrelated q: this crate uses lunarity 0.1. Is there a point in upgrading to 0.2?

lunarity 0.2 does bump up performance

[dvdplm]

lunarity 0.2 does bump up performance

Can you add a ticket for it please? :)

[seunlanlege]

already bumped it

[seunlanlege]

rpc failing tests strike again.
@niklasad1 could you help restart CI

[niklasad1]

@seunlanlege done, but in the future, you can do it by yourself by just logging in to gitlab with your github account. Otherwise, ping the CI-team and they can help you :)

[niklasad1]

could be ok_or instead because it is just a value.

[niklasad1]

LGTM, feel free to merge this.

I added a couple of inline comments that are optional.

Also, the code uses return Err(e)? which https://rust-lang.github.io/rust-clippy/master/index.html#try_err doesn't like but I don't have any strong opinions on it seems fine.