Skip to content

quick n' dirty fix to get default store_view in default group #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2025
Merged

quick n' dirty fix to get default store_view in default group #8

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07a82bd
quick n' dirty fix to get default store_view in default group
Nolwennig-Jeulin Sep 9, 2025
25b700b
Fix store url matching rule
thomas-kl1 Sep 9, 2025
d49d1cf
Fix and clean preference score calculation
thomas-kl1 Sep 9, 2025
2180608
Fix syntax error
thomas-kl1 Sep 9, 2025
c895e26
Remove unnecessary condition
thomas-kl1 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions Plugin/App/Request/StorePathInfoValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,27 +92,39 @@ private function resolveByLinkUrl(string $uri): string

private function resolveByWebUrl(string $uri): string
{
$matches = [];
$storeMatch = null;
$highestScore = 0;

/** @var Store $store */
foreach ($this->storeRepository->getList() as $store) {
if ($store->getId() && str_starts_with($uri, $store->getBaseUrl(UrlInterface::URL_TYPE_WEB))) {
try {
$website = $store->getWebsite();
if ($website->getIsDefault()) {
if ($store->isDefault()) {
return $store->getCode();
}
$matches[0] = $store->getCode();
} elseif ($store->isDefault()) {
$matches[1] = $store->getCode();
} else {
$matches[2] = $store->getCode();
$score = $this->calculatePreferenceScore($store);
$storeMatch ??= $store->getCode();
if ($highestScore < $score) {
$highestScore = $score;
$storeMatch = $store->getCode();
}
} catch (NoSuchEntityException) {}
}
}

return $matches[0] ?? $matches[1] ?? $matches[2] ?? '';
return $storeMatch ?? '';
}

/**
* @throws NoSuchEntityException
*/
private function calculatePreferenceScore(Store $store): int
{
$website = $store->getWebsite();
// Bonus point for the stores which are part of one of the groups from the default website.
$score = $website->getIsDefault() ? 2 : 0;
// Extra point for the stores which are part of the default group of its website.
$score += (int)$website->getDefaultGroup()->getDefaultStoreId() === (int)$store->getId() ? 1 : 0;
// Extra point is the store is the default one of its group.
$score += $store->isDefault() ? 1 : 0;

return $score;
}
}