Skip to content

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Dec 3, 2024

Followup to bump copyright years that were missed in: #22327


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345389: Bump missed copyright years for JDK-8336768 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22513/head:pull/22513
$ git checkout pull/22513

Update a local copy of the PR:
$ git checkout pull/22513
$ git pull https://git.openjdk.org/jdk.git pull/22513/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22513

View PR using the GUI difftool:
$ git pr show -t 22513

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22513.diff

Using Webrev

Link to Webrev Comment

@JornVernee JornVernee changed the title Bump copyright years 8345389: Bump missed copyright years for JDK-8336768 Dec 3, 2024
@JornVernee JornVernee marked this pull request as ready for review December 3, 2024 12:53
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2024

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345389: Bump missed copyright years for JDK-8336768

Reviewed-by: pminborg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 3, 2024
@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Dec 3, 2024

Webrevs

Copy link
Contributor

@minborg minborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 3, 2024
@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 3, 2024

Going to push as commit 157a434.
Since your change was applied there have been 20 commits pushed to the master branch:

  • a49f077: 8345221: Replace legacy with new Provider APIs in SunNativeGSS
  • 2be07b5: 8324491: Keyboard layout didn't keep its state if it was changed when dialog was active
  • f37f64d: 8343736: Test java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java failed: Choice can't be controlled by keyboard
  • 73b8b34: 8344368: IndependenceSwingTest.java and IndependenceAWTTest.java failed: Selected text & clipboard contents differs
  • 9267dfa: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19
  • 293323c: 8340141: C1: rework ciMethod::equals following 8338471
  • 76e874c: 8345319: Fix the tag type in PoolEntry and AnnotationValue
  • e9f6ba0: 8345293: Fix generational Shenandoah with compact headers
  • e1910f2: 8345397: Remove from g1HeapRegionRemSet.cpp
  • 3c60f0b: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed
  • ... and 10 more: https://git.openjdk.org/jdk/compare/8cad0431ff17992fadbb593319ad3821b32e3b7e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 3, 2024
@openjdk openjdk bot closed this Dec 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2024
@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@JornVernee Pushed as commit 157a434.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JornVernee JornVernee deleted the BumpYears branch December 3, 2024 20:29
@JornVernee JornVernee restored the BumpYears branch December 4, 2024 12:20
@JornVernee JornVernee deleted the BumpYears branch December 4, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants