-
Notifications
You must be signed in to change notification settings - Fork 545
8370912: Formatting error on JavaDoc because of missing quotation mark #1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Corrected a missing closing quote in the HBox JavaDoc example, ensuring it's properly formatted.
|
Hi @ISO53, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ISO53" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
@ISO53 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@ISO53 If you would like to proceed with this PR, please sign the Oracle Contributor Agreement (OCA) as indicated in the Contributing Guidelines and then enter |
|
@kevinrushforth I've signed it. It's still under review. Patiently waiting :) |
OK. You can enter a |
|
/signed |
|
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
Webrevs
|
|
The doc change looks good. Can you do two more things?
|
|
Changed the PR title. Actions is already enabled. |
You must have enabled them after you pushed to your branch. Double-check that they are enabled, and then either manually trigger a GHA run or else push an empty commit ( |
|
@ISO53 Are you sure you have enabled GHA for your repo? To check, go to https://github.com/ISO53/jfx/actions in your browser. If you see a green button to enable workflows with a message similar to "I understand, enable workflows", press the green button. Then you will need to either manually rerun or push another empty commit. |
|
Ok, my bad. Now it runs the tests. |
kevinrushforth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for fixing it.
Since this is a trivial doc-only fix, a single review is sufficient. You may integrate this PR when ready.
|
/integrate |
|
/sponsor |
|
Going to push as commit 11cff5d.
Your commit was automatically rebased without conflicts. |
|
@andy-goryachev-oracle @ISO53 Pushed as commit 11cff5d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Corrected a missing closing quote in the HBox JavaDoc example, ensuring it's properly formatted.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1956/head:pull/1956$ git checkout pull/1956Update a local copy of the PR:
$ git checkout pull/1956$ git pull https://git.openjdk.org/jfx.git pull/1956/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1956View PR using the GUI difftool:
$ git pr show -t 1956Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1956.diff
Using Webrev
Link to Webrev Comment