Skip to content

Conversation

@ISO53
Copy link
Contributor

@ISO53 ISO53 commented Oct 30, 2025

Corrected a missing closing quote in the HBox JavaDoc example, ensuring it's properly formatted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370912: Formatting error on JavaDoc because of missing quotation mark (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1956/head:pull/1956
$ git checkout pull/1956

Update a local copy of the PR:
$ git checkout pull/1956
$ git pull https://git.openjdk.org/jfx.git pull/1956/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1956

View PR using the GUI difftool:
$ git pr show -t 1956

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1956.diff

Using Webrev

Link to Webrev Comment

Corrected a missing closing quote in the HBox JavaDoc example, ensuring it's properly formatted.
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 30, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2025

Hi @ISO53, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ISO53" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 30, 2025

@ISO53 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370912: Formatting error on JavaDoc because of missing quotation mark

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@kevinrushforth
Copy link
Member

@ISO53 If you would like to proceed with this PR, please sign the Oracle Contributor Agreement (OCA) as indicated in the Contributing Guidelines and then enter /signed in a comment in this PR.

@ISO53
Copy link
Contributor Author

ISO53 commented Nov 1, 2025

@kevinrushforth I've signed it. It's still under review. Patiently waiting :)

@kevinrushforth
Copy link
Member

I've signed it. It's still under review. Patiently waiting :)

OK. You can enter a /signed comment while waiting if you like.

@ISO53
Copy link
Contributor Author

ISO53 commented Nov 1, 2025

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Nov 1, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Nov 4, 2025
@openjdk openjdk bot added the rfr Ready for review label Nov 4, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2025

Webrevs

@kevinrushforth
Copy link
Member

The doc change looks good. Can you do two more things?

  1. I removed the trailing . from the JBS issue title (at Skara's suggestion). Can you update your PR title to match (no change needed to the code, since the commit message in your branch isn't used).
  2. Please enable running GitHub actions in your repo to allow a GHA run for sanity testing.

@ISO53 ISO53 changed the title 8370912: Formatting error on JavaDoc because of missing quotation mark. 8370912: Formatting error on JavaDoc because of missing quotation mark Nov 5, 2025
@ISO53
Copy link
Contributor Author

ISO53 commented Nov 5, 2025

Changed the PR title. Actions is already enabled.

@kevinrushforth
Copy link
Member

Actions is already enabled.

You must have enabled them after you pushed to your branch. Double-check that they are enabled, and then either manually trigger a GHA run or else push an empty commit (git commit --allow-empty -m empty; git push) to your branch.

@kevinrushforth
Copy link
Member

@ISO53 Are you sure you have enabled GHA for your repo? To check, go to https://github.com/ISO53/jfx/actions in your browser. If you see a green button to enable workflows with a message similar to "I understand, enable workflows", press the green button. Then you will need to either manually rerun or push another empty commit.

@ISO53
Copy link
Contributor Author

ISO53 commented Nov 5, 2025

Ok, my bad. Now it runs the tests.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing it.

Since this is a trivial doc-only fix, a single review is sufficient. You may integrate this PR when ready.

@openjdk openjdk bot added the ready Ready to be integrated label Nov 5, 2025
@ISO53
Copy link
Contributor Author

ISO53 commented Nov 5, 2025

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@ISO53
Your change (at version f69e5e5) is now ready to be sponsored by a Committer.

@andy-goryachev-oracle
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

Going to push as commit 11cff5d.
Since your change was applied there have been 9 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 5, 2025
@openjdk openjdk bot closed this Nov 5, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@andy-goryachev-oracle @ISO53 Pushed as commit 11cff5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants