fix: Release 0.8.1; find compatible versions fixes; remove pip vendored imports; #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous sort did not work reliably, since sort was not using the packaging.Version semver sort key.
- Pip vendored imports are generally discouraged, mainly because their behaviour varies from currently installed pip version. A much more correct solution is to install the vendored packages. - To resolve, add packaging>=24.1 as a dependency and fix imports
These test relied on older versions of setuptools,pip and wheel dependencies
sale3
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_compatible_upgrade_versionssort order by usingkey=Version.from pip._vendorprefix from imports, as they are generally discouraged.