test: adjust tests for next@16 #3169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
test all versions
pieh
force-pushed
the
test-cache-tag-index
branch
from
4561a34 to
ee4f245
Compare
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
added
test latest and canary
pieh
commented
Oct 10, 2025
Comment on lines
+31
to
+46
| const shouldTestAllVersions = labels.some(label => label.name === 'autorelease: pending' || label.name === 'test all versions'); | ||
| if (shouldTestAllVersions) { | ||
| return 'all' | ||
| } | ||
| return labels.some(label => label.name === 'test latest and canary') ? 'latest-and-canary' : 'latest' | ||
| - name: Set Next.js versions to test | ||
| id: set-matrix | ||
| # If this is the nightly build or a release PR then run the full matrix of versions | ||
| run: | | ||
| if [ "${{ github.event_name }}" == "workflow_dispatch" ]; then | ||
| echo "matrix=${{ github.event.inputs.versions }}" >> $GITHUB_OUTPUT | ||
| elif [ "${{ github.event_name }}" = "schedule" ] || [ "${{ steps.check-labels.outputs.result }}" = "true" ]; then | ||
| elif [ "${{ github.event_name }}" = "schedule" ] || [ "${{ steps.check-labels.outputs.result }}" = "all" ]; then | ||
| echo "matrix=[\"latest\", \"canary\", \"14.2.15\", \"13.5.1\"]" >> $GITHUB_OUTPUT | ||
| elif [ "${{ steps.check-labels.outputs.result }}" = "latest-and-canary" ]; then | ||
| echo "matrix=[\"latest\", \"canary\"]" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
adding way to run just latest and canary variants without v13 and v14 to save CI time while working on adjustments for Next@16
pieh
force-pushed
the
test-cache-tag-index
branch
from
fac5db3 to
f4ed061
Compare
pieh
force-pushed
the
test-cache-tag-index
branch
from
f4ed061 to
18f7ee7
Compare
pieh
commented
Oct 10, 2025
| // (14.2.10 and canary.147) | ||
| const shouldHavePrivateDirective = nextVersionSatisfies( | ||
| '<14.2.4 || >=14.2.10 <15.0.0-canary.24 || ^15.0.0-canary.147', | ||
| '<14.2.4 || >=14.2.10 <15.0.0-canary.24 || >=15.0.0-canary.147', |
There was a problem hiding this comment.
updated to have v16 fall into version range
pieh
commented
Oct 10, 2025
Comment on lines
+18
to
+24
| experimental: pprConfigHardDeprecated | ||
| ? { | ||
| cacheComponents: true, | ||
| } | ||
| : { | ||
| ppr: true, | ||
| }, |
There was a problem hiding this comment.
experimental.ppr hard fails now forcing to use experimental.cacheComponents
This does introduce also introduce some changes to some behaviors and ppr test was adjusted for it as well
pieh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Details either in code comments or inline comments