-
Notifications
You must be signed in to change notification settings - Fork 51
Refactor: Standardize refactor + add test suite #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…d to avoid degen. polygons issue
Thanks for the pull request and apologies for the delay in responding. This is great work. One main question before merging – what testing beyond the added unit tests (which are great!) have you done on e2e usage? Want to minimize the risk for surprises and inadvertently breaking something. |
Good point. I tested the current master versus this PR on the four projects linked below, which I’ve also listed in a short “Projects using scad-utils” section at the end of the README. In Projects using scad-utils |
Summary
Comprehensive cleanup and refactor of the OpenSCAD utility libraries and test suite.
tests/
suite.Review Notes
Documentation (README.md)
.scad
files.$fn
, edge-case notes).Source Changes (Highlights)
All files reformatted consistently, with standardized headers and preserved behavior.
invert_rt
. Moved general-purpose matrix utilities (matrix_power
,det
,matrix_invert
) here fromspline.scad
for logical separation of concerns.subarray
.col
tint param, preserved BSD license.shell()
behavior, renamedinverse()
→_inverse()
.$fn
dependence, preserved behavior.[tx,ty,tz,yaw,pitch,roll]
, documented translation/rotation inputs.Test Changes (NEW)
mirror()
, optional color tint.