Skip to content

LOG-7535: Add MaxUnavailable to API and enable kube caching #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

LOG-7535: Add MaxUnavailable to API and enable kube caching #3118

merged 1 commit into from
Oct 10, 2025

Conversation

@jcantrill
Copy link
Contributor

@jcantrill jcantrill commented Sep 24, 2025 •
edited by openshift-ci bot
Loading

Description

This PR:

  • enables by default kube api caching for kubernetes_log sources
  • Ignores the kube api cache annotation introduced in LOG-7196
  • Deprecates the MaxUnavailable annotation introduced by LOG-7196
  • Exposes MaxUnavailable as a CLF field to modify the collector daemonset upgrade rollout strategy which is preferred over the annotation

Links

https://issues.redhat.com/browse/LOG-7535

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2025 •
edited by openshift-ci bot
Loading

@jcantrill: This pull request references LOG-7535 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

  • enables by default kube api caching for kubernetes_log sources
  • Ignores the kube api cache annotation introduced in LOG-7196
  • Deprecates the MaxUnavailable annotation introduced by LOG-7196
  • Exposes MaxUnavailable as a CLF field to modify the collector daemonset upgrade rollout strategy which is preferred over the annotation

Links

https://issues.redhat.com/browse/LOG-7535

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2025
@jcantrill
Copy link
Contributor Author

jcantrill commented Sep 24, 2025

cc @cahartma @vparfonov @Clee2691

@jcantrill
Copy link
Contributor Author

jcantrill commented Sep 25, 2025

/retest

@jcantrill
Copy link
Contributor Author

jcantrill commented Sep 25, 2025

/test functional-target

@jcantrill
Copy link
Contributor Author

jcantrill commented Sep 29, 2025

/retest

1 similar comment
@jcantrill
Copy link
Contributor Author

jcantrill commented Sep 29, 2025

/retest

vparfonov
vparfonov reviewed Oct 7, 2025
View reviewed changes
api/observability/v1/clusterlogforwarder_types.go Outdated
// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Affinity"
Affinity *corev1.Affinity `json:"affinity,omitempty"`

// Define the maxUnavailable pod rollout strategy
Copy link
Contributor

@vparfonov vparfonov Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not set will be used default value 100% right?
maybe need to add this information here in doc.

vparfonov
vparfonov reviewed Oct 7, 2025
View reviewed changes
api/observability/v1/clusterlogforwarder_types.go Outdated
//
// Value can be a number (e.g., 50) or a percentage string (e.g., "50%").
// +kubebuilder:validation:Type=string
// +kubebuilder:validation:Pattern="^([0-9]{1,2}|100)$|^([0-9]{1,2}|100)%$"
Copy link
Contributor

@vparfonov vparfonov Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// +kubebuilder:validation:Pattern="^([0-9]{1,2}|100)$|^([0-9]{1,2}|100)%$"
// +kubebuilder:validation:Pattern="^(?:[0-9]{1,2}|100)%?$"

regexp can be simplified : https://regex101.com/r/LiZGfZ/3

@vparfonov
Copy link
Contributor

vparfonov commented Oct 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025

/retest-required

Remaining retests: 0 against base HEAD d3372cd and 2 for PR HEAD e60ea04 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
Clee2691
Clee2691 reviewed Oct 10, 2025
View reviewed changes
api/observability/v1/clusterlogforwarder_types.go
// Value can be a number (e.g., 50) or a percentage string (e.g., "50%").
// +kubebuilder:validation:Type=string
// +kubebuilder:validation:Pattern="^(?:[0-9]{1,2}|100)%?$"
MaxUnavailable *intstr.IntOrString `json:"maxUnavailable,omitempty"`
Copy link
Contributor

@Clee2691 Clee2691 Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a descriptor for the console?
+operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Max Unavailable"

@Clee2691
Copy link
Contributor

Clee2691 commented Oct 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025

/retest-required

Remaining retests: 0 against base HEAD cecd635 and 2 for PR HEAD f8604ec in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4e5a324 into openshift:master Oct 10, 2025
7 checks passed
@jcantrill jcantrill deleted the log7535 branch October 13, 2025 14:48
@jcantrill jcantrill mentioned this pull request Oct 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanconway alanconway Awaiting requested review from alanconway

2 more reviewers

@vparfonov vparfonov vparfonov left review comments

@Clee2691 Clee2691 Clee2691 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vparfonov vparfonov

@Clee2691 Clee2691

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/6.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jcantrill @openshift-ci-robot @vparfonov @Clee2691